Re: [Nagios-devel] 2 calls to unlink in checkresults

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] 2 calls to unlink in checkresults

Post by Guest »

Gerhard Lausser wrote:
> Hi,
>
> i reported this bug in january
> http://archive.netbsd.se/?ml=nagios-dev ... &m=9671673
> http://archive.netbsd.se/?ml=nagios-dev ... &m=9671670
> Imo, the condition for the second unlink needs to be reversed.
>

Hmm. That would also be a bit off, imo. A better solution would
be to write the file directly to the check_result_path and then
just create the .ok file when checking is done. In that case, we
won't need to worry about cross-filesystem renames (which are
expensive since they always incur 4 disk-seeks and one memcopy).
Granted, the two of the seeks should always be cached, but it's
still 2 cold ones we can avoid entirely.

--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231

Register now for Nordic Meet on Nagios, June 3-4 in Stockholm
http://nordicmeetonnagios.op5.org/

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked