Michael Friedrich wrote:
[snip]
>>
>> if(data==NULL)
>> - return;
>> + return return_code;
>
> I don't think this should be treated like this in regard of checking
> data if NULL. Currently the return code not checked for OK|ERROR when
> calling the function, but each call provides a void* typecasted svc or
> hst for the data function param. In regard of continuous behavior I
> would recommend changing that the way I proposed before - by returning
> ERROR instead of OK, if data is NULL. see broker_host|service_check for
> examples on returning return_code. It won't affect anything right now,
> just keeping source clean.
>
> Kind regards,
> Michael
>
Agreed! Changed in CVS.
--
Ethan Galstad
Father of Nagios
___
Email: [email protected]|com
Web: www.nagios.com
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]