Re: [Nagios-devel] vanished bug numbers in the nagios mantis tracker

[Guest]

I tried to rework the attribuitions a bit since the
levels of >>> were getting a bit much. I am not sure if
I was successful or not in making in clearer who said
what but.

In message ,
Andreas Ericsson writes:
[Andreas 8/7] On 08/06/2012 05:12 PM, John P. Rouillard wrote:
[rouilj 8/6] In message , Andreas Ericsson writes:
[andreas 8/3?] On 08/03/2012 05:15 PM, John P. Rouillard wrote:
[rouilj 8/3] In message , Andreas Ericsson writes:
[Andreas 8/3] On 08/03/2012 10:27 AM, Wim Hoekman wrote:
[Win 8/3] On 2012-08-01 10:37, Andreas Ericsson wrote:

[Andreas 8/1] This one might resolve itself in Nagios 4, when we change
[Andreas 8/1] how checks are run. I won't investigate it further until
[Andreas 8/1] that's out anyway though.

[Wim 8/3] The release of Nagios 4 would be a great time to import
[Wim 8/3] the Nagios patch I've submitted a while ago. (Subject:
[Wim 8/3] Additional image for action_url in host and service
[Wim 8/3] definitions patch)
[Wim 8/3]
[Wim 8/3] That patch required a change to the object abi, so it
[Wim 8/3] was not included in any minor release.

[Andreas 8/3]
[Andreas 8/3] Is there a reason why we just can't make this a custom
[Andreas 8/3] variable with special meaning in the UI?
[Andreas 8/3]
[Andreas 8/3] I'm especially uninterested in patches that move more UI
[Andreas 8/3] code into the core, since that's something that really
[Andreas 8/3] should be going away rather than increase.

[rouilj 8/3] One of the things that frustrated me to no end when creating
[rouilj 8/3] the external correlation event broker
[rouilj 8/3] (http://www.cs.umb.edu/~rouilj/sec_nagio ... manual.txt)
[rouilj 8/3] was that the broker architecture provided no mechanism for
[rouilj 8/3] the plugin to add items to the objects and provide parsers
[rouilj 8/3] for the objects in config files.

[Andreas 8/3?]
[Andreas 8/3?] That would be pretty awesome, but "adding items to the
[Andreas 8/3?] object" is simply not possible. C-objects are carved in stone
[Andreas 8/3?] once the code is compiled, and nothing but the module will
[Andreas 8/3?] ever know or care about the extra data.

[rouilj 8/6]
[rouilj 8/6] So add a field that is a pointer to a nagios maintained data
[rouilj 8/6] store for each object. Where each object in the datastore is a
[rouilj 8/6] key/value (blob pointer) pair. "adding items to the object"
[rouilj 8/6] wasn't meant as add a new field. More along the lines of add a
[rouilj 8/6] new item to a linked list in the object.
[rouilj 8/6]
[Andreas 8/7] Why on earth would you prefer O(n) complexity over O(1)?
[Andreas 8/7] Do you realize that you're requesting something that's
[Andreas 8/7] both slower and more complex than what I proposed?

Arrays are fixed length. What do you expect to use for the size
of the array? I agree being able to do an address lookup at

array_start + n*(sizeof pointer)

is a win, but it's also a good way to end up wasting a lot of
space by oversizing the array at compile time to support an
undeterminable number of brokers/plugins/modules. After all every
object (host, service) will need this array. An alternative is
to take some time to traverse a linked list (or binary tree, hash
table ....) and reducing the amount of memory needed.

Now if you are taking about mallocing the array and allowing the
number of elements in the array to be set in the config file
that's something different, but I saw no indication of that.

Ideally to save on memory you would want a configuation setting
for each object type, but a single setting for all objects would
probably work without too much waste.

[rouilj 8/3] Custom variables help a little bit but introduce the need to
[rouilj 8/3] parse the value on every event which is not acceptable. The
[rouilj 8/3] value should be parsed once into a quickly accessible form
[rouilj 8/3] (e.g. bitfield) and carried around with the object.
[rouilj 8/3]
[andreas 8/3] Well, no. You might want to add things other than flags in
[andreas 8/3] such variables and you may well have severa

...[email truncated]...


This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]