>
> On 28 Jan 2010, at 09:36, Andreas Ericsson wrote:
>
>> In fact, passing a comment id to the API at
>> all is, to me, totally superfluous and counterproductive.
>
> It is required at some level because when reading the retention.dat
> you need to know existing comment ids, otherwise it will keep changing.
>
Not necessarily. Parsing the blocks into a meta-data structure and then
passing one such structure into the comment api would suffice to hide
comment id's from the adding parts of the api. The generic block-reading
code could also double as config reader, so that all other parts of
Nagios only have to deal with the meta-data format.
But whatever. Fixing the startup time isn't really something I'm itching
to do, so if the suggested patches get fixed to your liking I'm
completely satisfied with leaving the decision on how to do it in
yours and Jonathan's capable hands
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]