Re: [Nagios-devel] Unable to stop executing checks with 3.2.2

[Guest]

--gj572EiMnwbLXET9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 18, 2010 at 06:57:54PM +0100, Ton Voon said:
> The test_events.c passes with this change. However, it would be best =20
> if a testcase could be written for the problem this is trying to =20
> solve, which fails without the patch and passes with the patch. This =20
> will ensure the problem will continue to get visibility in future.
>=20
> If you create that testcase, I'd be more than happy to apply.

So I've been looking at the various test cases you already have, and I'm
not sure if it's going to be simpler to try to plug it into test_events.c
or create a new one, so I'm going to outline my thoughts and ask for a
recommendation.

The things that this patch addresses and should be tested are (in pseudo
code):

if execute_service_checks =3D=3D 1 and execute_host_checks =3D=3D 1:
failed service_check schedules a host_check and executes it
service_check is rescheduled

else if execute_service_checks =3D=3D 0 and execute_host_checks =3D=3D 1:
service_check is rescheduled instead of executed
host_check is scheduled at it's normal interval and executed

else if execute_service_checks =3D=3D 1 and execute_host_checks =3D=3D 0:
failed service_check schedules a host_check
host_check is rescheduled instead of run
service_check is rescheduled

else if execute_service_checks =3D=3D 0 and execute_host_checks =3D=3D 0:
a service_check is rescheduled
a host_check is rescheduled

That covers my understanding of how the scheduling should work.

Any advice on where to put that? I admit at first glance I am slightly
daunted by the prospect of learning your test harness for the logic
above, but I'm willing to try.

Cheers,
--=20
--------------------------------------------------------------------------
| Stephen Gran | Exhilaration is that feeling you get |
| [email protected] | just after a great idea hits you, and |
| http://www.lobefin.net/~steve | just before you realize what is wrong |
| | with it. |
--------------------------------------------------------------------------

--gj572EiMnwbLXET9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJMlessAAoJELMRjO+K6o/udjAQAMv/lwhaoW6umoPpHjyeYTGL
lsFU72lTH2aNHdC6ZsiL5ClTHzNMnHodfDu0xlJONQu/B1q4o+UarrOHN12m4Mdt
cFkeStroIj0RtKYaZNNjMivpc4NvEsI/1Io8qTUY39XfMCNjWgIvJor0wcRKUqJj
QgS9ogq69IPK78NJwXFq2PvahCjtZyCxfAUaQWUPZlBUo8mKSIM1KT57T1eBfZ3+
VFQ2qEjm5xzbbAcx2RCN3+tIWzzjeHgzHiYEGmV6vRrpQxzFzNyJn17fjslw4ptj
xuqCCJANbjClAIO3ltFHcL5RDTHJ2mZylYuOTh/R+I7CC/n3Et2gQ5lThKjJA/Y3
EuqYGGt2wXDxuuZXJSt2lwQaSsMZ23bGyYwn6mwfN6+y/6YMuzsFCNYJFKUai5cV
Mv9DVg2abf27FzSGJ2A1yE6wMy+wu1jOZ9pe2OAk8jCF3Wdduxcjx6y0a/vps2qu
y88UNqHq5T31Q4RJcoRMQjM1YAiKeHFShszQe4ZF04DKtjpxU5CQwKwVoZjhQSZE
Gm/JUgSec1K6deq2+xvlvddv3Kfn9ZYSGam/f7HjusJ8KsHMtNhIUs4FUmy4tqdS
4vJsCjGi3SNH+8WNXBqPIMFUUoCDj/Ws2a+hiR5Y7FW0i9WG8CqCaMUd4SLCtCwt
sMfo2iVS6B57wLRVusIb
=yvdx
-----END PGP SIGNATURE-----

--gj572EiMnwbLXET9--





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]