> On Wed, Jun 17, 2009 at 10:50:41AM +0200, Andreas Ericsson wrote:
>> Ethan Galstad wrote:
>>>> Andreas Ericsson schrieb:
>>> The only thing anyone should be mucking with when making changes is
>>> configure.in. The "configure" script has been in CVS for ages, and
>>> there's no reason to take it out now. I don't really think there's an
>>> absolute requirement that all the core devs use the same autoconf
>>> version, as long as its somewhat recent. Makes it a hell of a lot
>>> easier to just to a CVS checkout and run ./configure, which helps with
>>> automated scripts.
>>>
>> There are two problems with this.
>>
>> The first is patch review. If someone makes a change to configure.in
>> and re-generates configure from it with a more recent version of autoconf
>> the patch will be *huge*, but the actual change might be 3-4 lines.
>
> i would say at the least it would be good form to split them into seperate
> commits, so that one could see the "actual" change vs the "10000 lines of
> noise" change.
>
That's a good idea, but it removes the atomicity and means the build
product isn't the same as the source for one particular commit. A
bugger, really.
>> Personally I like what the plugins do about this, shipping a microscopic
>> script that just issues the autoconf commands so one doesn't have to
>> remember them.
>
> yeah. i'd go so far as to call this a "best practice" for using autoconf,
> i.e. shipping a "bootstrap.sh" or "autogen.sh" which does some sanity checks
> and then generates the autofoo stuff.
>
> for 3rd party distributers (i.e. debian and other distros), as soon as you
> have to make one change in the build system, the out-of-the-box configure
> scripts become pretty burdensome to deal with.
>
> i'd say the existance of a hypothetical autogen script plus nightly snapshots
> ought to placate most of the arguments behind having ./configure in the VCS.
>
Yup. One could even go so far as to build a snapshot tarball on every push.
> granted i'm not the most active with nagios these days, but i have to
> deal with this type of problem all the time and it's a major PITA to
> deal with so i figured i'd just chip in my 0.16 SEK
>
Oh right, you live in Sweden now. And you still haven't given me the
opportunity to buy you a beer or ten
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]