RE : RE : [Nagios-devel] Re: Re : Patch submission for comments :

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

RE : RE : [Nagios-devel] Re: Re : Patch submission for comments :

Post by Guest »

This is a multi-part message in MIME format.

------------7NhE3WuB9OnU6N9D2A0R5Y7
Content-Type: multipart/alternative;
boundary="----_=_NextPart_001_01C56DAC.FA165FE0"

This message is in MIME format. Since your mail reader does not understand
this format, some or all of this message may not be legible.

------_=_NextPart_001_01C56DAC.FA165FE0
Content-Type: text/plain; charset="iso-8859-1"

> I think you're wrong about the memory leaks (although I
> whole-heartedly
> agree about the malloc()'s). Nagios has struggled recently
> with severe
> memory leaks and some valgrind sessions has narrowed it down to
> virtually nothing. Perhaps you aren't running recent CVS code?

Sure, but I just wrote that because somebody asked a question about
templates and to know what happens if you submit more than one "use" line in
an object definition. In this case, and like for every string directive, the
strdup creates a memory leak because the previous value is not tested to be
null. It is a special case because it is an incorrect syntax but either it
is refused and stops in error (what I would prefer), or it is accepted, the
previous value is silently discarded, and we should free the previous memory
block.

------_=_NextPart_001_01C56DAC.FA165FE0
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: Quoted-Printable






RE : RE : [Nagios-devel] Re: Re : Patch submission for comments : CG=
I speed improvement (XNG)



> I think you're wrong about the memory leaks (althoug=
h I
> whole-heartedly
> agree about the malloc()'s). Nagios has struggled r=
ecently
> with severe
> memory leaks and some valgrind sessions has narrowe=
d it down to
> virtually nothing. Perhaps you aren't running recen=
t CVS code?


Sure, but I just wrote that because somebody asked a ques=
tion about templates and to know what happens if you submit more than one &=
quot;use" line in an object definition. In this case, and like for eve=
ry string directive, the strdup creates a memory leak because the previous =
value is not tested to be null. It is a special case because it is an incor=
rect syntax but either it is refused and stops in error (what I would prefe=
r), or it is accepted, the previous value is silently discarded, and we sho=
uld free the previous memory block.




------_=_NextPart_001_01C56DAC.FA165FE0--

------------7NhE3WuB9OnU6N9D2A0R5Y7
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: Quoted-Printable

Ce message et ses pi=E8ces jointes (le "message") est destin=E9 =E0 l'usage=
=20
exclusif de son destinataire. =20
Si vous recevez ce message par erreur, merci d'en aviser imm=E9diatement =

l'exp=E9diteur et de le d=E9truire ensuite. Le pr=E9sent message pouvant =
=20
=EAtre alt=E9r=E9 =E0 notre insu, CALYON Corporate and Investment Bank =
=20
ne peut pas =EAtre engag=E9 par son contenu. Tous droits r=E9serv=E9s.=20
=20
This message and/or any attachments (the "message") is intended for =20
the sole use of its addressee. =20
If you are not the addressee, please immediately notify the sender and =20
then destroy the message. As this message and/or any attachments may=20
have been altered without our knowledge, its content is not legally=20
binding on CALYON Corporate and Investment Bank. All rights reserved. =
=20

------------7NhE3WuB9OnU6N9D2A0R5Y7--





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked