Re: [Nagios-devel] [patch] Fix invalid DOM in CGI
Posted: Fri Dec 09, 2011 2:48 pm
On 12/09/2011 03:23 PM, Sven-Göran Bergh wrote:
> Attached patch fixes an invalid DOM.
>
> A table element may not have a form
> element as a direct child, but the
> opposite is OK.
>
> The forms become invalid in some browsers
> when the CGI:s are AJAX loaded in div
> element.
>
Neat patch, but why not start the table directly after the form?
That way it would have been obvious that the patch doesn't change
the layout. Now it's split so I can't say for sure that it
doesn't without having to look at the code, and I won't have
time to do that until next week. Care to reroll and resend a
more easily reviewed patch?
Thanks.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> Attached patch fixes an invalid DOM.
>
> A table element may not have a form
> element as a direct child, but the
> opposite is OK.
>
> The forms become invalid in some browsers
> when the CGI:s are AJAX loaded in div
> element.
>
Neat patch, but why not start the table directly after the form?
That way it would have been obvious that the patch doesn't change
the layout. Now it's split so I can't say for sure that it
doesn't without having to look at the code, and I won't have
time to do that until next week. Care to reroll and resend a
more easily reviewed patch?
Thanks.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]