Re: [Nagios-devel] nsca and nrpe2 syslog facility
Posted: Tue Nov 20, 2007 3:07 pm
Brian A. Seklecki wrote:
> On Tue, 2007-11-20 at 11:00 +0100, Andreas Ericsson wrote:
>> Brian A. Seklecki wrote:
>>> nsca.c @ line 134 of 1450
>>>
>>> openlog("nsca",LOG_PID|LOG_NDELAY,LOG_DAEMON);
>>>
>>> prototype: void openlog(const char *ident, int logopt, int facility);
>>>
>>> We should probably make that a config-file defined variable. At the
>>> *very* least, a GNU autoconf compile-time configure option -> #DEFINE
>>>
>> Err... say what now?
>
> The facility should be adjustable away from LOG_DAEMON
>
Well, it's OSS. Make a nice and clean patch and it's likely to get accepted.
The kind of networks where you really, really need the very slight speedup
you're getting from a bitwise operation on a parsed string over a memcmp(3)
will have someone competent enough to make the necessary modifications.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
> On Tue, 2007-11-20 at 11:00 +0100, Andreas Ericsson wrote:
>> Brian A. Seklecki wrote:
>>> nsca.c @ line 134 of 1450
>>>
>>> openlog("nsca",LOG_PID|LOG_NDELAY,LOG_DAEMON);
>>>
>>> prototype: void openlog(const char *ident, int logopt, int facility);
>>>
>>> We should probably make that a config-file defined variable. At the
>>> *very* least, a GNU autoconf compile-time configure option -> #DEFINE
>>>
>> Err... say what now?
>
> The facility should be adjustable away from LOG_DAEMON
>
Well, it's OSS. Make a nice and clean patch and it's likely to get accepted.
The kind of networks where you really, really need the very slight speedup
you're getting from a bitwise operation on a parsed string over a memcmp(3)
will have someone competent enough to make the necessary modifications.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]