Re: [Nagios-devel] Variables encoded twice

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] Variables encoded twice

Post by Guest »

Bernd Arnold wrote:
> In statusmap.c, layout_method is an int and therefore shouldn't be
> escaped (the compiler put a message since int was passed as parameter
> where a char* is expected). File escape_string-2.diff, lines 271/273.
>
>
> The HTML was broken when using apostrophs in the host name and/or the
> host alias (statusmap.cgi) and having escape_html_tags=0 in cgi.cfg.
> This is corrected in the patch. (escape_html_tags should only
> influence the plugin output.)
>
> I've patched cmd.cgi to escape host, service and author names and the
> comment data. The call of url_encode is replaced by escape_string
> there. As a side effect, the author's name is displayed correctly now
> ("Nagios+Admin" before, "Nagios Admin" with the patch).
>
> The file escape_string-3.diff includes Armin's patches
> (escape_string-2.diff) and my patches described above.
>
>> cgiutils.h is generated from cgiutils.h.in by autoconf and is not
>> in CVS.
>
> Thanks. I've used the configure script to generate the cgiutils.h
> file after your patch.
>
> Regards Bernd
>

Thanks for the work on this guys. I'll get this applied to CVS shortly.


- Ethan Galstad





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked