[Nagios-devel] Convert CHECK to SEARCH to avoid unnecessarily

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

[Nagios-devel] Convert CHECK to SEARCH to avoid unnecessarily

Post by Guest »

--001636025c7c92af8d0474c030ae
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi;
CVS delta 1.147 -> 1.148 includes un-dnl-ing some AC_CHECK_LIBS for USL/SVR=
4
-derivative Unix environments.

Note that the act of CHECK_LIBS (main) -- which is used to avoid having to
give an entry point/label -- is also replaced by the actual name of an entr=
y
point.

For details, see also:

http://www.gnu.org/software/autoconf/ma ... aries.html


The following change converts this Solaris edit to a SEARCH rather than a
CHECK, which works on all platforms, and only adds additional librarires if
the mentioned linker entry points are not already valid in the current list
of libraries:


--- configure.in.solaris 2009-09-30 00:48:17.000000000 +0100
+++ configure.in 2009-09-30 00:51:37.000000000 +0100
@@ -101,9 +101,8 @@


dnl Checks for library functions.
-AC_CHECK_LIB(nsl,main,SOCKETLIBS=3D"$SOCKETLIBS -lnsl")
-AC_CHECK_LIB(socket,socket,SOCKETLIBS=3D"$SOCKETLIBS -lsocket")
-AC_SUBST(SOCKETLIBS)
+AC_SEARCH_LIBS([getservbyname],[nsl])
+AC_SEARCH_LIBS([connect],[socket])
AC_CHECK_FUNCS(initgroups setenv strdup strstr strtoul unsetenv)

AC_MSG_CHECKING(for type of socket size)



Note: this also drops the need for "SOCKETLIBS" tracking. Libs add the nsl
(NameServices lib) and socket (yeah, socket) libraries only if the
pre-existing libraries (libc, libC, et al) don't already provde the lib.

This check is really intended for the merge-point where sockets moved from
being environmental things to in-kernel things, and not all executables
wanted to link with sockets included by default.


Please, someone on Solaris, consider this change, and check for me.

Allan


--=20
[email protected] "=E9=87=91=E9=B1=BC" http://linkedin.com/in/gold=
fish
Sent from Manchester, Eng, United Kingdom

--001636025c7c92af8d0474c030ae
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi;CVS delta 1.147 -> 1.148 includes un-dnl-ing some=
AC_CHECK_LIBS for USL/SVR4 -derivative Unix environments.Note that the act of CHECK_LIBS (main) -- which is used to avoid h=
aving to give an entry point/label -- is also replaced by the actual name o=
f an entry point.
For details, see also:h=
ttp://www.gnu.org/software/autoconf/manual/ht ... aries.html
The following change converts this Solar=
is edit to a SEARCH rather than a CHECK, which works on all platforms, and =
only adds additional librarires if the mentioned linker entry points are no=
t already valid in the current list of libraries:
--- configure.in.solaris 2009-09-30 00:48:17.0=
00000000 +0100+++ configure.in 2009-09-=
30 00:51:37.000000000 +0100
@@ -101,9 +101,8 @@=C2=A0=C2=A0=C2=A0=
dnl Checks for library functions.-AC_CHECK_LIB(nsl,main,SOCKETLI=
BS=3D"$SOCKETLIBS -lnsl")-AC_CHECK_LIB(socket,socket,S=
OCKETLIBS=3D"$SOCKETLIBS -lsocket")
-AC_SUBST(SOCKETLIBS)+AC_SEARCH_LIBS([getservbyname],[nsl])=
+AC_SEARCH_LIBS([connect],[socket])=C2=A0AC_CHECK_FUN=
CS(initgroups setenv strdup strstr strtoul unsetenv)=C2=A0=
=C2=A0AC_MSG_CHECKING(for type of socket size)
Note: this also drops the=
need for "SOCKETLIBS" tracking. =C2=A0Libs add the nsl (NameServ=
ices lib) and socket (yeah, socket) libraries only if the pre-existing libr=
aries (libc, libC, et al) don't already provde the lib.
This check is really intended for the merge-poi

...[email truncated]...


This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked