Re: [Nagios-devel] skiplist insert free?

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] skiplist insert free?

Post by Guest »

On Tue, 2008-09-30 at 00:27 -0400, Thomas Guyot-Sionnest wrote:
> This looks valid... update is malloc'ed and initialized with NULLs right
> above the diff chunk... It seems like a temporary buffer and is freed at
> all other places.

cool.

>
> Even better would be placing this check before the malloc as there's no
> need to malloc it there if we're going to return. You can pull my
> *absolutely untested* patch here...

yeah I agree, much better solution. thanks.

>
> http://solaris.beaubien.net/cgi-bin/git ... agios.git/
>
>
> - --
> Thomas
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFI4aqv6dZ+Kt5BchYRAhoGAKDxN2V1osbD+wRILcws1N7VwZ9DHgCcD0lO
> 0D7k/e/bHpinDn+VqeK5hew=
> =s/BO
> -----END PGP SIGNATURE-----






This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked