apply these (the ones that Ton didn't beat me to, anyways). See
minor comment below though.
On 05/12/2011 01:13 PM, Andreas Ericsson wrote:
> On 05/12/2011 09:19 AM, Michael Friedrich wrote:
>> Hi Ton,
>>
>> Ton Voon wrote:
>
>>>> [PATCH] move thread safe macro function prototypes with suffix _r and restore old compatible prototypes again
>>>>
>>>> => verified against latest t-tap tests, updated .gitignore
>>>> 0003-move-thread-safe-macro-function-prototypes-with-suff.patch
>>> I don't know enough around this area, but I know Andreas is keen on re-entrant functions, so I'll defer to him.
>>
>> Possibly, maybe it also needs some further adaptions. It's not business
>> critical, just compatibility critical for addon developers.
>>
>
> I'm fairly sure I applied that one, but perhaps I was lacking the
> proper amount of alcohol in my bloodstream and forgot to do the
> git -> cvs export step. The patch is good and will be applied though,
> since it would otherwise force us to bump the major version of Nagios
> for the next release. Thanks
>
Taken, with the exception of the cgi parts. Since the cgi's aren't
multi-threaded, they don't really need reentrant macro functions
and the change to them is just churn with no benefit.
>>>>
>>>> 0004-fix-flexible-downtime-on-service-hard-state-change-d.patch
>>> This one requires a test case too, due to its complexity. See t-tap/test_checks.c which has tests in the handle_async_check_results routine.
>>
>> Ok, thanks for the hint. In case there are any users in the Nagios world
>> happen to have the same problem, I'd love to see some reports after
>> having that patch applied against 3.2.3 or similarities.
>>
>
> Likewise. User-testing is very nearly as good as automated tests. At
> least for accepting the patch in the first place. Many thanks.
>
I'll take this on good faith, having tested it manually my self. It's
possible someone else can add a test-case for this in the future,
which would be a welcome change.
Expect the patches to show up in svn in a couple of hours when I'm
on a sane link and can sync properly again.
--
Andreas Ericsson [email protected]
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]