Re: [Nagios-devel] Fix for mktime() issue

[Guest]

--Apple-Mail-48-464634053
Content-Type: text/plain;
charset=ISO-8859-1;
format=flowed;
delsp=yes
Content-Transfer-Encoding: quoted-printable

Hi!

This patch was applied to Nagios Core and was in 3.2.0. I've fixed a =20
specific problem last year with timeperiods when DST moved back one =20
hour, but I didn't change the other occurrences of this patch. My =20
feeling was to get a test case for the specific changes before =20
reverting the patch.

However, I think there are still some timezone issues (as mentioned by =20=

Mark Frost on nagios-users), so I'm thinking that I should revert the =20=

entire patch and instead say that if you want to add the isdst=3D-1 in, =20=

then add test cases in.

Opinions?

Ton

On 30 Dec 2008, at 17:36, Albrecht Dre=DF wrote:

> Hi all:
>
> please find attached to this message a diff against the current cvs =20=

> which fixes a strange issue in Nagios 3.0.6 I discovered a while ago =20=

> [1, 2]. Using it on my Ubuntu Hardy server since then, it seems to =20=

> properly fix the issue. As always, any comment is welcome!
>
> All the best for a happy, healthy and prosperous new year 2009,
> Cheers,
> Albrecht.
>
> [1]
> [2]
> bug=20
> .diff=20
> >=20
> =
--------------------------------------------------------------------------=
----
> _______________________________________________
> Nagios-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/lis ... gios-devel

Ton Voon
Product Architect




Opsera Limited | Unit 69 Suttons Business Park
Reading | Berkshire | RG6 1AZ | UK

Phone: +44 (0) 845 057 7887
Mobile: +44 (0) 7931 365796
Skype: tonvoon Email: [email protected]
www.opsera.com
This e-mail is confidential, intended only for the named recipient(s) =20=

above and may contain information that is privileged and confidential. =20=

If you receive this message in error, or are not the named =20
recipient(s), please notify the sender at the phone number above, do =20
not copy this message, do not disclose its contents to anyone, and =20
delete this e-mail message from your computer. Although Opsera =20
routinely screens for viruses, addressees should scan this e-mail and =20=

any attachments for viruses. Opsera makes no representation or =20
warranty as to the absence of viruses in this e-mail or any =20
attachments. Opsera Limited is registered in the UK under Company =20
Number 5396532. Our registered office is Gorse View, Horsell Rise, =20
Woking, Surrey, GU21 4RB.


--Apple-Mail-48-464634053
Content-Type: multipart/related; boundary=Apple-Mail-49-464634054;
type="text/html"


--Apple-Mail-49-464634054
Content-Type: text/html;
charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi!This =
patch was applied to Nagios Core and was in 3.2.0. I've fixed a specific =
problem last year with timeperiods when DST moved back one hour, but I =
didn't change the other occurrences of this patch. My feeling was to get =
a test case for the specific changes before reverting the =
patch.However, I think there are still some =
timezone issues (as mentioned by Mark Frost on nagios-users), so I'm =
thinking that I should revert the entire patch and instead say that if =
you want to add the isdst=3D-1 in, then add test cases =
in.Opinions?TonOn 30 Dec 2008, at 17:36, Albrecht Dre=DF =
wrote:Hi all:please find attached to this message a =
diff against the current cvs which fixes a strange issue in Nagios 3.0.6 =
I discovered a while ago [1, 2].  Using it on my Ubuntu Hardy =
server since then, it seems to properly fix the issue.  As always, =
any comment is welcome!<b

...[email truncated]...


This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]