[Nagios-devel] host flapping update when actual check and wait time
Posted: Sat Feb 28, 2009 3:06 pm
This is a multi-part message in MIME format.
--------------080804030906090108020700
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
if there wasn't an actual check, and the wait time was below the
required, an update should not be done. this is what is indicated by
comments, but doesn't seem to be done in the implementation. please see
if the attached diff is valid. thanks.
--------------080804030906090108020700
Content-Type: text/x-patch;
name="hostflapping.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="hostflapping.diff"
--- base/flapping.c 2008-11-30 19:22:58.000000000 +0200
+++ /tmp/flapping.c 2009-02-28 16:48:40.000000000 +0200
@@ -223,8 +223,10 @@
}
/* if we didn't have an actual check, only update if we've waited long enough */
- if(update_history==TRUE && actual_check==FALSE && (current_time-hst->last_state_history_update)last_state_history_update)state_history[(hst->state_history_index==0)?MAX_STATE_HISTORY_ENTRIES-1:hst->state_history_index-1];
@@ -234,7 +236,7 @@
if(last_state_history_value==hst->current_state)
return;
#endif
- }
+#endif
/* what thresholds should we use (global or host-specific)? */
low_threshold=(hst->low_flap_thresholdlow_flap_threshold;
--------------080804030906090108020700--
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
--------------080804030906090108020700
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
if there wasn't an actual check, and the wait time was below the
required, an update should not be done. this is what is indicated by
comments, but doesn't seem to be done in the implementation. please see
if the attached diff is valid. thanks.
--------------080804030906090108020700
Content-Type: text/x-patch;
name="hostflapping.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="hostflapping.diff"
--- base/flapping.c 2008-11-30 19:22:58.000000000 +0200
+++ /tmp/flapping.c 2009-02-28 16:48:40.000000000 +0200
@@ -223,8 +223,10 @@
}
/* if we didn't have an actual check, only update if we've waited long enough */
- if(update_history==TRUE && actual_check==FALSE && (current_time-hst->last_state_history_update)last_state_history_update)state_history[(hst->state_history_index==0)?MAX_STATE_HISTORY_ENTRIES-1:hst->state_history_index-1];
@@ -234,7 +236,7 @@
if(last_state_history_value==hst->current_state)
return;
#endif
- }
+#endif
/* what thresholds should we use (global or host-specific)? */
low_threshold=(hst->low_flap_thresholdlow_flap_threshold;
--------------080804030906090108020700--
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]