--_002_40FF3EB574329C459B49338F779CE44E014DC83E0Ebosmail2k7adv_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
See attached.
Note that I made this change with attention to the possibility that the cod=
e might end up being made multithreaded at some point in the future, so I f=
etch the peer's IP address with getpeername in each function that needs it,=
rather than storing it in static memory.
jik
-----Original Message-----
From: Hendrik Baecker [mailto:[email protected]]
Sent: Tuesday, December 16, 2008 2:43 AM
To: Nagios Developers List
Subject: Re: [Nagios-devel] nsca patch to do better error logging?
Kamens, Jonathan schrieb:
>
> To debug this particular problem as well as to make it easier to debug
such problems in the future, I modified the NSCA source code to do
better logging of errors like this. It's a straightforward but useful
change. Is there any chance of getting it folded back into the master
source tree, and if so, to whom should I send it?
>
Sure, the chance exist. Send your unified diff against the latest cvs
code to this list and be sure that some guys out of the community will
review it.
--_002_40FF3EB574329C459B49338F779CE44E014DC83E0Ebosmail2k7adv_
Content-Type: application/octet-stream; name="nsca.patch"
Content-Description: nsca.patch
Content-Disposition: attachment; filename="nsca.patch"; size=7647;
creation-date="Tue, 16 Dec 2008 09:42:30 GMT";
modification-date="Tue, 16 Dec 2008 09:44:58 GMT"
Content-Transfer-Encoding: base64
SW5kZXg6IHNyYy9uc2NhLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3QvbmFnaW9zL25z
Y2Evc3JjL25zY2EuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNgpkaWZmIC11IC1yMS4yNiBu
c2NhLmMKLS0tIHNyYy9uc2NhLmMJMTUgSmFuIDIwMDggMjI6MjY6MDAgLTAwMDAJMS4yNgorKysg
c3JjL25zY2EuYwkxNiBEZWMgMjAwOCAxNDo0NDo1OCAtMDAwMApAQCAtODE1LDEzICs4MTUsNDUg
QEAKICAgICAgICAgfQogCiAKK3N0YXRpYyBpbnQgZ2V0X3BlZXJfaW5mbyhpbnQgc29jaywgY2hh
ciAqKnBlZXJfaXAsIGludCAqcGVlcl9wb3J0KQoreworICBzdHJ1Y3Qgc29ja2FkZHIgYWRkcjsK
KyAgc3RydWN0IHNvY2thZGRyX2luICpucHRyOworICBzb2NrbGVuX3QgYWRkcmxlbjsKKyAgaW50
IHJjOworCisgIC8qIEluaXRpYWxpemUgdG8gbnVsbCB2YWx1ZXMgKi8KKyAgaWYgKHBlZXJfaXAp
CisgICAgKnBlZXJfaXAgPSAwOworICBpZiAocGVlcl9wb3J0KQorICAgICpwZWVyX3BvcnQgPSAw
OworCisgIGFkZHJsZW4gPSBzaXplb2YoYWRkcik7CisgIHJjID0gZ2V0cGVlcm5hbWUoc29jaywg
JmFkZHIsICZhZGRybGVuKTsKKyAgaWYgKHJjIDwgMCkgeworICAgIHJldHVybiByYzsKKyAgfQor
CisgIG5wdHIgPSAoc3RydWN0IHNvY2thZGRyX2luICopJmFkZHI7CisKKyAgaWYgKHBlZXJfaXAp
IHsKKyAgICBpZiAoISAoKnBlZXJfaXAgPSBzdHJkdXAoaW5ldF9udG9hKG5wdHItPnNpbl9hZGRy
KSkpKSB7CisgICAgICByZXR1cm4gLTE7CisgICAgfQorICB9CisgIAorICBpZiAocGVlcl9wb3J0
KSB7CisgICAgKnBlZXJfcG9ydCA9IG50b2hzKG5wdHItPnNpbl9wb3J0KTsKKyAgfQorCisgIHJl
dHVybiAwOworfQogCiBzdGF0aWMgdm9pZCBhY2NlcHRfY29ubmVjdGlvbihpbnQgc29jaywgdm9p
ZCAqdW51c2VkKXsKICAgICAgICAgaW50IG5ld19zZDsKICAgICAgICAgcGlkX3QgcGlkOwotICAg
ICAgICBzdHJ1Y3Qgc29ja2FkZHIgYWRkcjsKLSAgICAgICAgc3RydWN0IHNvY2thZGRyX2luICpu
cHRyOwotICAgICAgICBzb2NrbGVuX3QgYWRkcmxlbjsKKwljaGFyICpwZWVyX2lwOworCWludCBw
ZWVyX3BvcnQ7CiAgICAgICAgIGludCByYzsKICNpZmRlZiBIQVZFX0xJQldSQVAKIAlzdHJ1Y3Qg
cmVxdWVzdF9pbmZvIHJlcTsKQEAgLTkwMSw4ICs5MzMsNyBAQAogICAgICAgICAgICAgICAgIH0K
IAogICAgICAgICAvKiBmaW5kIG91dCB3aG8ganVzdCBjb25uZWN0ZWQuLi4gKi8KLSAgICAgICAg
YWRkcmxlbj1zaXplb2YoYWRkcik7Ci0gICAgICAgIHJjPWdldHBlZXJuYW1lKG5ld19zZCwmYWRk
ciwmYWRkcmxlbik7CisgICAgICAgIHJjPWdldF9wZWVyX2luZm8obmV3X3NkLCZwZWVyX2lwLCZw
ZWVyX3BvcnQpOwogCiAgICAgICAgIGlmKHJjPDApewogICAgICAgICAgICAgICAgIC8qIGxvZyBl
cnJvciB0byBzeXNsb2cgZmFjaWxpdHkgKi8KQEAgLTkxNSwxMSArOTQ2LDExIEBACiAJCXJldHVy
bjsKICAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgbnB0cj0oc3RydWN0IHNvY2thZGRyX2lu
ICopJmFkZHI7Ci0KICAgICAgICAgLyogbG9nIGluZm8gdG8gc3lzbG9nIGZhY2lsaXR5ICovCiAg
ICAgICAgIGlmKGRlYnVnPT1UUlVFKQotICAgICAgICAgICAgICAgIHN5c2xvZyhMT0dfREVCVUcs
IkNvbm5lY3Rpb24gZnJvbSAlcyBwb3J0ICVkIixpbmV0X250b2EobnB0ci0+c2luX2FkZHIpLG5w
dHItPnNpbl9wb3J0KTsKKwkgIHN5c2xvZyhMT0dfREVCVUcsIkNvbm5lY3Rpb24gZnJvbSAlcyBw
b3J0ICVkIixwZWVyX2lwLCBwZWVyX3BvcnQpOworCisJZnJlZShwZWVyX2lwKTsKIAogCS8qIGhh
bmRsZSB0aGUgY29ubmVjdG
...[email truncated]...
This post was automatically imported from historical nagios-devel mailing list archives
Original poster: endrik Baecker [mailto:[email protected]