Re: [Nagios-devel] [PATCH] Unused variables x and found_macro_x on

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] [PATCH] Unused variables x and found_macro_x on

Post by Guest »



----- Original Message -----
> On 06/22/2012 08:57 PM, Ricardo Maraschini wrote:
> > hello,
> >=20
> > i've removed two unused variables on found_macro_x() function.
> > Compiler errors:
> >=20
> > ../common/macros.c: In function =E2=80=98process_macros_r=E2=80=99:
> > ../common/macros.c:133:6: warning: variable =E2=80=98found_macro_x=E2=
=80=99 set but
> > not used [-Wunused-but-set-variable]
> > ../common/macros.c:128:6: warning: variable =E2=80=98x=E2=80=99 set but=
not used
> > [-Wunused-but-set-variable]
> >=20
> >=20
> > OK? Comments?
> >=20
>=20
> Test this with macro resolution debugging turned on. I just
> reverted a patch that did this change (and a bunch of other
> -Wunused-but-set-variable), and removing the unused ones
> actually broke macro resolution for the core.

Just for curiosity, the patch you've reverted had the same logic as mine re=
garding strcmp()?


-rm





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked