Re: [Nagios-devel] Significant NRPE rework, including IPv6

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] Significant NRPE rework, including IPv6

Post by Guest »

On 12 Mar 2011, at 13:20, Kristian Lyngst=F8l wrote:

> I've started working on making NRPE somewhat maintainable, as it's a
> bit of a mess in its current state.
>=20
> The original goal was adding IPv6-support, which I've done, but it has
> escalated somewhat after that.
>=20
> I've since:
>=20
> - Transitioned to autotools/autoconf for a somewhat more convenient
> build system
> - ... Introduced system-wide header files (...)
> - Started sorting out what's local and global, removing redundant
> prototypes and declaring functions static
> - Imported a couple of patches kept by Debian that were reasonable.
> - Re-indented the code (Normally I wouldn't do this on a project
> that's not mine, but I wasn't able to wrap my head around the style as
> it was -- too far off)
> - Removed several redundant comments (Stuff like "/* wait for
> connections */ wait_for_connections();" which only serves as noise)
> - Removed unused or unneeded code.
> - Misc other
>=20
> While the IPv6-support is fairly complete (using getaddrinfo()), the
> nrpe-server needs two more features to be release-ready: Listening to
> both ipv4 and ipv6 at the same time, and ipv6-awareness in
> allowed_hosts. This is on my todo-list. I also expect I've broken the
> build on certain platforms, and I intend to test this to some degree.
>=20
> The work can be found at: https://github.com/KristianLyng/nrpe
>=20
> I do not want to maintain a fork, thus I'm interested to co-operate to
> get this "upstream". Since the code looked almost abandoned, I decided
> that it would be best to adapt a "fix first, ask later"-approach.
>=20
> I've so far dubbed it NRPE "3.0", and I'm using it both nrpe-server
> and check_nrpe on several servers.
>=20
> Any and all feedback is much welcomed.

Kristian,

If you could incorporate this enhancement, that would be great:=20

http://labs.opsview.com/2008/08/enhanci ... ge-output/

We return a "version 3" in the packet data.

I would like this to get back upstream too, but I don't have commit =
access to the NRPE areas.

Ton






This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked