Page 1 of 1

Graphs from check_mssql_server.py

Posted: Mon Feb 09, 2015 3:57 am
by Ivica Mustapic
Guys,

We have problems with graphs from the check_mssql_server.py script.

The perfdata.log file has the following message:
2015-02-09 16:27:33 [5248] [1] Found Performance Data for XXXXXXX / MSSQL_Lock_Wait_Times (lockwait=77175.0ms;;;;;)
2015-02-09 16:27:33 [5248] [1] Invalid Perfdata detected

When testing from the command line we have:
./check_mssql_server.py -H vsmurprdsql01 -U 'XXXXX' -P 'XXXXXX' -p 1433 --lockwait
OK: Lock Wait Average Time (ms) is 696292.0ms|lockwait=696292.0ms;;;;;

Could it be that the quotation marks are not supplied by the check_mssql_server.py script in the performance part of the output?
All other graphs are working fine, only the graph generated by check_mssql_server.py are not.

Our NagiosXI version is: 2014R2.4
and check_mssql_server.py time stamp is:
-rwxr-xr-x 1 nagios users 20215 Oct 3 2013 ./check_mssql_server.py

Cheers
Ivica

Re: Graphs from check_mssql_server.py

Posted: Mon Feb 09, 2015 9:22 am
by nagiosnl_jorgen
Well, I found the same problem. This plugin does not meet the https://nagios-plugins.org/doc/guidelines.html Nagios Plugin Development Guidelines requirements:
2015-01-12 14:38:26 [4226] [1] Invalid Perfdata detected
Please notice that - for instance -
(database_pages=3451927.0;300;600;;;)
has one semicolon too much at the end. Either the trailing semicolons should be skipped or reduced to two semicolons.
The three semicolons are hardcodes so it's easy to fix.

Regards,
Jørgen van der Meulen
Solutions Consultant

http://www.nagios.nl

Re: Graphs from check_mssql_server.py

Posted: Mon Feb 09, 2015 10:28 am
by tmcdonald
This has already been filed internally and fixed. It should be included in the next release. I will be closing this topic now.