Page 1 of 1

check_mssql_server.py "Average Wait Time"

Posted: Tue Apr 17, 2018 8:24 am
by hatebur
According to Microsofts counter type definition (see https://blogs.msdn.microsoft.com/psssql ... _counters/) the "Average Wait Time (ms)" counter is of type PERF_AVERAGE_BULK, and should be measured from two samples.
Currently, as far as i understand, the "Average Wait Time" in the Script check_mssql_server.py, Version 2.1.0, 06/24/2016, is calculated from only one sample of counter "Average Wait Time (ms)" directly divided by counter "Average Wait Time Base". See attached picture.
example_data.jpg
Is there a chance that you could update the plugin so this metric is calculated more accurate?

Re: check_mssql_server.py "Average Wait Time"

Posted: Tue Apr 17, 2018 8:58 am
by scottwilkerson
Would you be willing to make an issue on the public tracker for this open source plugin?
https://github.com/NagiosEnterprises/ch ... collection

I could copy over your info, but you seem informed about the Microsoft specs, and I would like you to get credit for the find.

Thanks

Re: check_mssql_server.py "Average Wait Time"

Posted: Wed Apr 18, 2018 1:22 am
by hatebur
Thank you for the fast reply, i just posted the issue on GitHub.

Re: check_mssql_server.py "Average Wait Time"

Posted: Wed Apr 18, 2018 7:01 am
by scottwilkerson
Thanks! Locking thread