Hi there
I am wondering why the simple typo requests are still not processed/reviewd by core developers.
Example: https://github.com/NagiosEnterprises/na ... l/22/files
Who is reviewing github pull requests ?
-
scottwilkerson
- DevOps Engineer
- Posts: 19396
- Joined: Tue Nov 15, 2011 3:11 pm
- Location: Nagios Enterprises
- Contact:
Re: Who is reviewing github pull requests ?
We have not made a full release since this request was made.
Re: Who is reviewing github pull requests ?
Thanks scott for responding my question. I am new comer to Nagios and like to learn more about the development work flow.scottwilkerson wrote:We have not made a full release since this request was made.
But shouldn't the master branch contain all the latest fixes from community developers ?
and fixes got merged into branch 4.1 later when making release for official 4.1.
-
scottwilkerson
- DevOps Engineer
- Posts: 19396
- Joined: Tue Nov 15, 2011 3:11 pm
- Location: Nagios Enterprises
- Contact:
Re: Who is reviewing github pull requests ?
Honestly, because your pull request contains a promotion to your misspell_fixer, it's not likely to be pulled strait in anyways.
Re: Who is reviewing github pull requests ?
I am not connected to misspell_fixer in anyway,fist time hear of such open-source tool. I am using this typo pull request as example.scottwilkerson wrote:Honestly, because your pull request contains a promotion to your misspell_fixer, it's not likely to be pulled strait in anyways.
Looking at the changes in typos, I (a beginner) don't see why a direct pull in is not possible, no functional changes.
Thanks for assigning someone to look into the existing pull requests. prompt pull requests interaction will encourage others to become nagios core developers.
Re: Who is reviewing github pull requests ?
You are welcome.nagmoto wrote:Thanks for assigning someone to look into the existing pull requests. prompt pull requests interaction will encourage others to become nagios core developers.
Former Nagios employee
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.