Who is reviewing github pull requests ?

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
nagmoto
Posts: 195
Joined: Fri Jan 09, 2015 8:05 am

Who is reviewing github pull requests ?

Post by nagmoto »

Hi there
I am wondering why the simple typo requests are still not processed/reviewd by core developers.
Example: https://github.com/NagiosEnterprises/na ... l/22/files
scottwilkerson
DevOps Engineer
Posts: 19396
Joined: Tue Nov 15, 2011 3:11 pm
Location: Nagios Enterprises
Contact:

Re: Who is reviewing github pull requests ?

Post by scottwilkerson »

We have not made a full release since this request was made.
Former Nagios employee
Creator:
Human Design Website
Get Your Human Design Chart
nagmoto
Posts: 195
Joined: Fri Jan 09, 2015 8:05 am

Re: Who is reviewing github pull requests ?

Post by nagmoto »

scottwilkerson wrote:We have not made a full release since this request was made.
Thanks scott for responding my question. I am new comer to Nagios and like to learn more about the development work flow.

But shouldn't the master branch contain all the latest fixes from community developers ?
and fixes got merged into branch 4.1 later when making release for official 4.1.
scottwilkerson
DevOps Engineer
Posts: 19396
Joined: Tue Nov 15, 2011 3:11 pm
Location: Nagios Enterprises
Contact:

Re: Who is reviewing github pull requests ?

Post by scottwilkerson »

Honestly, because your pull request contains a promotion to your misspell_fixer, it's not likely to be pulled strait in anyways.
Former Nagios employee
Creator:
Human Design Website
Get Your Human Design Chart
nagmoto
Posts: 195
Joined: Fri Jan 09, 2015 8:05 am

Re: Who is reviewing github pull requests ?

Post by nagmoto »

scottwilkerson wrote:Honestly, because your pull request contains a promotion to your misspell_fixer, it's not likely to be pulled strait in anyways.
I am not connected to misspell_fixer in anyway,fist time hear of such open-source tool. I am using this typo pull request as example.
Looking at the changes in typos, I (a beginner) don't see why a direct pull in is not possible, no functional changes.

Thanks for assigning someone to look into the existing pull requests. prompt pull requests interaction will encourage others to become nagios core developers.
abrist
Red Shirt
Posts: 8334
Joined: Thu Nov 15, 2012 1:20 pm

Re: Who is reviewing github pull requests ?

Post by abrist »

nagmoto wrote:Thanks for assigning someone to look into the existing pull requests. prompt pull requests interaction will encourage others to become nagios core developers.
You are welcome.
Former Nagios employee
"It is turtles. All. The. Way. Down. . . .and maybe an elephant or two."
VI VI VI - The editor of the Beast!
Come to the Dark Side.
Locked