Re: [Nagios-devel] [RFC] fork error in check.c

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] [RFC] fork error in check.c

Post by Guest »

Hendrik BŠäcker wrote:
> Hi List,
>
> since memory eating ePN is enabled as default in Nagios 3 some users ran
> into fork error cause of memory limits, but no one told them.
>
> They only see some log messages like: "Warning: The check of service xx
> could not be performed due to a fork() error."
>
> I've spent some time on the code and would suggest attached patch.
>
> Since the "fork_error" is only filled once in
> "run_async_service_check()", I guess it should be ok to move the logging
> earlier up to the fork error, so we could use strerror() to determine
> why the error occurs.
> But I am not sure if the part:
>
> if (fork_error == TRUE)
> return ERROR;
>
> has to stand at the last lines of the function or if we are able to
> return quiet after the fork error.
>
> It would be nice to see s.th. like sterror() in checks.c so that the
> users out there could imagine why an fork error occurs.
>
> Regards,
> Hendrik

Good idea Hendrik - I'll get this applied to host check fork() errors as
well. Thanks again.



Ethan Galstad
Nagios Developer
___
Email: [email protected]
Web: www.nagios.org





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked