Re: [Nagios-devel] ndoutils with zlib

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] ndoutils with zlib

Post by Guest »

This is a multi-part message in MIME format.

------_=_NextPart_001_01C95AB4.42E19AC3
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hello list,

> Umm. Are you *monitoring* 1000 machines or are you using 1000 machines =
to do
> the monitoring? Just curious.. :)
We are monitoring some 1000 systems (POS-Systems in a german Drugstore)

> Besides that, why not use lzo instead? It's a lot faster (although it =
doesn't
> compress as well), and it comes with a minilzo.c that can easily be =
included
> into the sources for those platforms where the zlib header files =
aren't
> installed.
I did not knew about it, i will have a look at it.

> What did I do?
>=20
> To make ndomod.c more readable, I refactored some of its
> functionality.
>=20
> First, I moved the option-parsing to extra files parseopt.[c|h]=20
> parseopt.h defines a struct to hold all configuration data for
> ndomod, replacing various global variables in ndomod.c. parseopt.c
> does the option-parsing with parameters given by nagios and the
> configuration file. It also contains the default values, formerly
> kept in ndomod.c.

This sounds like a worthy change in its own right, imo.
It should probably have been a patch of its own. I'll see what I
can make of it.

Fortunate, I have intermediate copies of my work. I will copy ndoutils =
with only this change this evening at =
http://joey.in-ulm.de/2008/ndoutils

> > I also [..]
> > I patched [..]
> > Finally [..]
>=20
> I'll say it again: minilzo.c would have been a ton better for you :-/
> [..]
> Since this is intended to be a performance booster, I'd like to see
> some real numbers on what the performance was before and how this
> patch changes it. If it's major code-surgery for a 10% increase, I
> think it's safe to say it'll be dropped on the floor, but if it ups
> performance by several orders of magnitude, I'd be very interested
> to work on it. Either way, some real numbers, please.

I'll try to gather some numbers.

> I tried to build a .diff-file, but I doubt the attached file is
> really usefull. I published the whole changed ndoutils at
> http://joey.in-ulm.de/2008/ndoutils Please have a look at it.
>=20
> It looks ok-ish, although far too large. I wish you'd have made
> several different patches of it so that each independant step
> could be reviewed and tested for correctness. As it stands now,
> it's two days worth of work to just review the entire patch,
> simply because the scope of the changes is so huge.

I agree, but we had to get it finished fast, because of =
christmas-shopping.

I'll diff and post the configuration-only refactored later this day.
Maybe this will be a good starting point for introducing minilzo.


Joey5337

------_=_NextPart_001_01C95AB4.42E19AC3
Content-Type: application/ms-tnef;
name="winmail.dat"
Content-Transfer-Encoding: base64

eJ8+IhcKAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEIgAcAGAAAAElQTS5NaWNy
b3NvZnQgTWFpbC5Ob3RlADEIAQ2ABAACAAAAAgACAAEEgAEAJgAAAEFXOiBbTmFnaW9zLWRldmVs
XSBuZG91dGlscyB3aXRoIHpsaWIAhw0BBYADAA4AAADYBwwACgALACwAFQADAEQBASCAAwAOAAAA
2AcMAAoACwAsABYAAwBFAQEJgAEAHwAAADQ2NkY4OUFERjlGNDQwODI1NUE5Q0I4OTA0OTgzOQC+
BgEDkAYAJA4AADkAAAADACYAAAAAAAMANgAAAAAAQAA5AMOa4UK0WskBHgA9AAEAAAAFAAAAQVc6
IAAAAAACAUcAAQAAAC8AAABjPURFO2E9IDtwPVBST0pFS1Q0MjtsPUFMUEhBLTA4MTIxMDEwNDQy
MVotMzcwAAAeAEkAAQAAACYAAABSZTogW05hZ2lvcy1kZXZlbF0gbmRvdXRpbHMgd2l0aCB6bGli
AAAAQABOAAA00dWpWskBHgBaAAEAAAARAAAAQW5kcmVhcyBFcmljc3NvbgAAAAACAVsAAQAAADgA
AAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAABBbmRyZWFzIEVyaWNzc29uAFNNVFAAYWVAb3A1LnNl
AAIBXAABAAAADwAAAFNNVFA6QUVAT1A1LlNFAAAeAF0AAQAAABEAAABBbmRyZWFzIEVyaWNzc29u
AAAAAAIBXgABAAAAOAAAAAAAAACBKx+kvqMQGZ1uAN0BD1QCAAAAAEFuZHJlYXMgRXJpY3Nzb24A
U01UUABhZUBvcDUuc2UAAgFfAAEAAAAPAAAAU01UUDpBRUBPUDUuU0UAAB4AZgABAAAABQAAAFNN
VFAAAAAAHgBnAAEAAAAKAAAAYWVAb3A1LnNlAAAAHgBoAAEAAAAFAAAAU01UUAAAAAAeAGkAAQAA
AAoAAABhZUBvcDUuc2UAAAAeAHAAAQAAACIAAABbTmFnaW9zLWRldmVsXSBuZG91dGlscyB3aXRo
IHpsaWIAAAACAXEAAQAAABsAAAAByVqqs9IxcTKTUNdC/oHygXp6yMqJAAHd0EwAHgB0AAEAAAAX
AAAATmFnaW9zIERldmVsb3BlcnMgTGlzdAAAHgAaDAEAAAAKAAAAVGlsbyBSZW56AAAAHg

...[email truncated]...


This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked