Re: [Nagios-devel] broker call in disable_service_notifications

Support forum for Nagios Core, Nagios Plugins, NCPA, NRPE, NSCA, NDOUtils and more. Engage with the community of users including those using the open source solutions.
Locked
Guest

Re: [Nagios-devel] broker call in disable_service_notifications

Post by Guest »

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Marc DeTrano schrieb:
> I believe I found a bug in commands.c, in : disable_service_notifications
>
> (around line 3540 or so in HEAD).
>
> The call to broker_adaptive_service_data comes before the switch to
> svc->notifications_enabled=FALSE.
>
> In enable_service_notifications, enable_host_notifications, and
> disable_host_notifications, the switch always comes before the broker is
> called. This means if you are trying to catch the disabling of
> service notifications in a broker module (as I am doing), you have no
> way to inspect the value of "notifications_enabled" to determine if this
> was just enabled or disabled.
>
Did you patched your nagios code to move the switch case before?
Is nagios doing it's job as before?
If so - please send a unified diff to this list. We will review and test
it. If it won't break s.th. else we will queue it for the developers to
upstream.

> Hope this helps, and thanks for all the great work on Nagios.
>
A patchfile should help more than thousand words ;)

- -
Hendrik
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkjy0WwACgkQlI0PwfxLQjnn0QCfaBUtYxn9dM59ycZtumuuVr1y
6UMAnRrEt1v2PSYuH7VIj+660RZb4H/I
=FLsg
-----END PGP SIGNATURE-----





This post was automatically imported from historical nagios-devel mailing list archives
Original poster: [email protected]
Locked